homework 4 #174
Open
homework 4 #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Component.Factory | ||
| interface Factory { | ||
| fun build(@BindsInstance app: App) : ApplicationComponent |
There was a problem hiding this comment.
- обычно метод в
Factoryназываютcreate,buildиспользуют вBuilder - тут нужно пробросить
Сontext, а неApp - нужно использовать квалификатор
@ApplicationContext, потому что он может бытьActivityContext
| import javax.inject.Qualifier | ||
|
|
||
| @MainActivityScope | ||
| @Component( |
There was a problem hiding this comment.
это должен быть Subcomponent для ApplicationComponent, а не отдельный компонент
|
|
||
| @Component.Factory | ||
| interface Factory { | ||
| fun build(@BindsInstance appContext: Context, |
There was a problem hiding this comment.
тут не нужно прокидывать и appContext и activity, достаточно будет @MainActivityContext context: Context, соответственно нужно создать @ApplicationContext аннотации:
@Qualifier
annotation class ApplicationContext
| class ReceiverViewModel( | ||
| class ReceiverViewModel @Inject constructor( | ||
| private val state: ColorState, | ||
| private val context: Context |
There was a problem hiding this comment.
тут мы получаем @ApplicationContext
| } | ||
| } | ||
|
|
||
| val MainActivity.Component: MainActivityComponent get() = this.component |
There was a problem hiding this comment.
обычно свойства с маленькой буквы MainActivity.сomponent
| private val color: ColorSaver, | ||
| private val colorGenerator: ColorGenerator, | ||
| private val context: Context | ||
| @param:MainActivityContext private val context: Context |
There was a problem hiding this comment.
тут получаем @ActivityContext
| annotation class MainActivityContext | ||
|
|
||
| @Module | ||
| object MainActivityModule { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.